Skip to content

Code Reviews

Question

Did you perform code reviews? How did that look like?

Short interview answer

A useful code review evaluates a focused proposed change before it is merged: reviewers check correctness, tests, security and maintainability risks, ask clear questions, and record an approval or requested changes. The exact workflow is a team practice, not a Git feature by itself.

Detailed answer

In a pull-request workflow, the author explains the goal, scope, and how the change was tested. Reviewers inspect the diff in manageable commits, compare it with the requirement, and leave specific comments or suggestions. The author responds, updates the branch, and the review is repeated until the change meets the team’s standards. Keep review feedback about the code and its impact, not the author; small pull requests are easier to understand and review than a large mixed change. Platforms can require approval before merge, but that control is most effective alongside shared review expectations.

Sources